-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freedom noises: Support "hex" as type
& packet
#4239
Conversation
add option for hex noise
Any binary data can be encoded as base64 (in your example |
@Fangliding when you send str or base64 , example: (also |
配置文件中可以指定是直接发送str(utf8)抑或是将输入的base64解码为byte并发送 |
base64 被发明出来就是用于编码 bytes 非可打印字符的,否则它和 str 有什么区别,并且 base64 比 hex 更紧凑(占用空间更少) 不过 hex 的好处是可读性更高,加一个 hex 也不是不可以,但这并不意味着你的说法是对的 |
yes you are right. we can convert hex to base64 even your base64 conversion is invalid i put in the config: the question is why we don't accept hex ? |
@GFW-knocker rebase 一下 |
@GFW-knocker 能开放你的仓库的修改权限吗 |
@GFW-knocker 或者你把我设为 collaborator |
I am not against this feature. The reason why I closed PR is that it cannot fix the issue and conflicts with the real fix |
@RPRX |
type
type
type
& packet
add option for hex noise.
we need to send noise packet in hex
for example :
QUIC header "ee0000000108aaaaaaaaaaaaaaaa000044d0" in hex
can't be represented in str or base64 with printable chars.
to see difference please check packets in wireshark with this config
this pr solve this issue: #4237